Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT prefix #492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MQTT prefix #492

wants to merge 3 commits into from

Conversation

MikeBishop
Copy link
Collaborator

Encountered two problems debugging MQTT not getting data in my environment:

  • For some reason, self.__master throws an exception trying to call any methods on the object, but renaming it to self.master works. I'm mystified why.
  • The existing code breaks when no prefix is set, rather than using the Teslamate default, and it doesn't account for an actual prefix being set which would change the number of levels in the split.

This is my attempt at fixing it. However, I don't run with any non-default prefix, so I'm not certain it's right. I just know it is working for me when not setting a prefix in either Teslamate or TWCManager.

However, it occurs to me that anyone who has it working probably does so by setting "teslamate" as their prefix. Do you think we should treat "teslamate" as equivalent to None? That messes up anyone who's actually using "teslamate" as their prefix in a Teslamate instance, but I don't know why one would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant